Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Add reason value and update documentation for on close reason #13877

Merged
merged 4 commits into from
Dec 12, 2018
Merged

[Menu] Add reason value and update documentation for on close reason #13877

merged 4 commits into from
Dec 12, 2018

Conversation

rfbotto
Copy link
Contributor

@rfbotto rfbotto commented Dec 11, 2018

  • Add reason value to Menu component onClose function
  • Add documentation about the reason value for Menu, Dialog and Popover

Closes #13833

@oliviertassinari oliviertassinari added component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Dec 11, 2018
@oliviertassinari oliviertassinari force-pushed the menu-missing-onclose-reason-and-documentation branch from 946193c to c5ae99c Compare December 11, 2018 22:59
@oliviertassinari oliviertassinari merged commit 04a698a into mui:master Dec 12, 2018
@oliviertassinari
Copy link
Member

Well done

This was referenced Sep 15, 2021
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfbotto @oliviertassinari